Skip to content
GitLab
Explore
Projects
Groups
Snippets
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Alan De Vaney
sdk-codegen
Commits
9524583f
Unverified
Commit
9524583f
authored
3 years ago
by
Bryn Ryans
Committed by
GitHub
3 years ago
Browse files
Options
Download
Email Patches
Plain Diff
fix: add children property to ExtensionProvider type (#1070)
parent
425aee50
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
packages/extension-sdk-react/src/components/ExtensionConnector/types.ts
+5
-0
...sion-sdk-react/src/components/ExtensionConnector/types.ts
packages/extension-sdk-react/src/components/ExtensionProvider2/ExtensionProvider2.tsx
+0
-2
.../src/components/ExtensionProvider2/ExtensionProvider2.tsx
packages/extension-sdk-react/src/components/ExtensionProvider40/ExtensionProvider40.tsx
+1
-4
...rc/components/ExtensionProvider40/ExtensionProvider40.tsx
with
6 additions
and
6 deletions
+6
-6
packages/extension-sdk-react/src/components/ExtensionConnector/types.ts
+
5
-
0
View file @
9524583f
...
...
@@ -24,6 +24,7 @@
*/
import
type
{
ReactNode
}
from
'
react
'
import
type
{
ExtensionHostApi
,
ExtensionSDK
}
from
'
@looker/extension-sdk
'
/**
...
...
@@ -93,6 +94,10 @@ export interface ExtensionProviderProps {
* Set to -1 for no timeout.
*/
chattyTimeout
?:
number
/**
* Children
*/
children
?:
ReactNode
}
export
interface
ExtensionConnectorProps
extends
ExtensionProviderProps
{
...
...
This diff is collapsed.
Click to expand it.
packages/extension-sdk-react/src/components/ExtensionProvider2/ExtensionProvider2.tsx
+
0
-
2
View file @
9524583f
...
...
@@ -24,7 +24,6 @@
*/
import
type
{
ReactNode
}
from
'
react
'
import
React
,
{
useState
}
from
'
react
'
import
type
{
ExtensionHostApi
}
from
'
@looker/extension-sdk
'
import
{
SdkConnection
}
from
'
@looker/extension-sdk
'
...
...
@@ -51,7 +50,6 @@ export const ExtensionContext2 = React.createContext<
export
interface
ExtensionProvider2Props
<
T
>
extends
ExtensionProviderProps
{
type
:
T
children
?:
ReactNode
}
/**
...
...
This diff is collapsed.
Click to expand it.
packages/extension-sdk-react/src/components/ExtensionProvider40/ExtensionProvider40.tsx
+
1
-
4
View file @
9524583f
...
...
@@ -24,7 +24,6 @@
*/
import
type
{
ReactNode
}
from
'
react
'
import
React
,
{
useState
}
from
'
react
'
import
type
{
ExtensionHostApi
}
from
'
@looker/extension-sdk
'
import
{
LookerExtensionSDK
}
from
'
@looker/extension-sdk
'
...
...
@@ -47,9 +46,7 @@ export const ExtensionContext40 = React.createContext<ExtensionContextData40>(
undefined
as
any
// no one will ever see this undefined!
)
export
interface
ExtensionProvider40Props
extends
ExtensionProviderProps
{
children
?:
ReactNode
}
export
interface
ExtensionProvider40Props
extends
ExtensionProviderProps
{}
/**
* ExtensionProvider40 component. Provides access to the extension API and SDK (use
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Explore
Projects
Groups
Snippets